feat(preset-wind4): add noscript & scripting variant in Tailwind 4.1
#4637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
commit: |
zyyv
approved these changes
May 5, 2025
@OverflowCat We can support all, but the default is align with |
antfu
approved these changes
May 6, 2025
|
The media feature is "scripting" but TW uses "noscript". If we want to
support other options, naming is an issue.
Chris ***@***.***> 于 2025年5月6日周二 10:52写道：
… *zyyv* left a comment (unocss/unocss#4637)
<#4637 (comment)>
Do we need to support all of them?
@OverflowCat <https://github.com/OverflowCat> We can support all, but the
default is align with tailwind when no value is given. Default is scripting:
none
—
Reply to this email directly, view it on GitHub
<#4637 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZ3LCWFWN3AAVKXSPGXUVL25APVVAVCNFSM6AAAAAB4O6GLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJTGEZTANBVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
zyyv
approved these changes
May 8, 2025
noscript & scripting variant in Tailwind 4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tailwindcss.com/blog/tailwindcss-v4-1#new-noscript-variant
Not adding it into the mini preset, as there are 3 values of the media feature. Do we need to support all of them?