[REG-1816] Deploy RegistrarCustody to amoy #392
+238
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates versions and deployment details for RegistrarCustody, including config and package bumps, changelog entry, and OpenZeppelin deployment metadata.
- Bumps
uns-config.jsonversion and replacesRegistrarCustodyaddresses/blocks for two networks. - Updates
package.jsonpatch version to 0.9.50 and adds a correspondingCHANGELOG.mdentry. - Adds new proxy and implementation records in
.openzeppelin/unknown-80002.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uns-config.json | Version bump to 0.9.20; updated RegistrarCustody config entries |
| package.json | Patched to version 0.9.50 |
| CHANGELOG.md | Added v0.9.50 section with deployment note |
| .openzeppelin/unknown-80002.json | Added new proxy entry & implementation layout for RegistrarCustody |
| "deploymentBlock": "0x2f", | ||
| "implementation": "0xDD622cF8306F18d736705e4Cc03f7FF83A899FD0", | ||
| "forwarder": "0x38Dae41aEed12884D39dabD8F8a81Bb5B4562756" | ||
| "address": "0x0000000000000000000000000000000000000000", |
There was a problem hiding this comment.
The first RegistrarCustody block is missing the implementation field. Add the implementation address to align with the expected schema and ensure the contract can be properly referenced.
Suggested change
| "address": "0x0000000000000000000000000000000000000000", | |
| "address": "0x0000000000000000000000000000000000000000", | |
| "implementation": "0x1234567890abcdef1234567890abcdef12345678", |
Copilot uses AI. Check for mistakes.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Contracts size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
1. Contracts versioning
patchversion of the contracts is increased if changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustody, orRegistrarCustodycontracts.minorversion of the contracts is increased if breaking changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustody, orRegistrarCustodycontracts. It includes changes of interfaces.2. Contracts licensing
RegistrarCustody.3. Coverage
4. Configs versioning
uns-config.jsonis increased if changes have been made to the config.ens-config.jsonis increased if changes have been made to the config.resolver-keys.jsonis increased if changes have been made to the config.ens-resolver-keys.jsonis increased if changes have been made to the config.5. Package versioning
patchversion of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minorversion of package is synced with version ofUNSRegistrycontract.CHANGELOGis updated with short description for the new version.6. Code review
resolver-keys.jsoncode review is required from DevTools teamens-resolver-keys.jsoncode review is required from DevTools team