Bump XMTP package to 2.0.7 #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All your tests were successful! We detected changes in the following:
|
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the XMTP package to version 2.0.7 and updates related code to accommodate the new API changes. Key changes include updating the getRemoteAttachment function to enforce type safety on the message content, refactoring client creation in getXmtpClient to use Client.build for existing clients, and updating type casts in ConversationBubble for remote attachments.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/src/components/Chat/protocol/xmtp.ts | Updated getRemoteAttachment to require DecodedMessage and refactored client restoration using Client.build. |
| packages/ui-components/src/components/Chat/modal/dm/ConversationBubble.tsx | Added explicit type casts for message content and remote attachment to align with XMTP package updates. |
Files not reviewed (1)
- packages/ui-components/package.json: Language not supported
Comments suppressed due to low confidence (2)
packages/ui-components/src/components/Chat/modal/dm/ConversationBubble.tsx:73
- [nitpick] The force-cast of message.content to a string should be reviewed to ensure that the content is always of type string when the ContentTypeText condition is met; consider implementing a type guard if edge cases are possible.
<Emoji>{message.content as string}</Emoji>
packages/ui-components/src/components/Chat/protocol/xmtp.ts:264
- The added check for message.content ensures that attachment loading does not proceed with invalid data. Verify that this validation is consistent with other message checks in the codebase to maintain uniform error handling.
if (!message.content) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP