8000 Added support for form.config.arrayFields. by apollo13 · Pull Request #756 · unpoly/unpoly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added support for form.config.arrayFields. #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

Added support for form.config.arrayFields. #756

merged 5 commits into from
Jun 24, 2025

Conversation

apollo13
Copy link
Contributor

No description provided.

@apollo13 apollo13 force-pushed the add-form-config-arrayfields branch 3 times, most recently from 782b754 to da94dcd Compare June 22, 2025 07:26
@apollo13 apollo13 mentioned this pull request Jun 22, 2025
Closed
@apollo13
Copy link
Contributor Author
apollo13 commented Jun 22, 2025 •
edited
Loading

Not sure about the firefox test failures. The log is a bit long (19 MB) and I don't know what to look for :D locally the up.form tests work fine. Any hints? I will test this later on against a real project.

@apollo13
Copy link
Contributor Author

Okay, locally this seems to work well. I had some problems getting up-validate to work since the docs seem to be wrong (https://unpoly.com/up-validate#validating-multiple-fields has the up-validate on the <label>-tag, it should be on the <input> instead right? Are the docs for 3.11 published somewhere, if it is not fixed there I'll submit a PR).

@apollo13
Copy link
Contributor Author

Fixed the up-validate docs as part of #757

@triskweline
Copy link
Contributor

Not sure about the firefox test failures. The log is a bit long (19 MB) and I don't know what to look for :D locally the up.form tests work fine. Any hints? I will test this later on against a real project.

I debugged this for a while, but to no avail. Firefox seem 8000 s to just stop accepting Pupeeteer commands after a while, and eventually the test runner times out. Upgrading Puppeteer didn't help either.

I removed Firefox from the CI matrix for now.

@apollo13 apollo13 force-pushed the add-form-config-arrayfields branch from da94dcd to 9344bf3 Compare June 23, 2025 11:25
@apollo13
Copy link
Contributor Author

Thanks, tests pass now :)

@triskweline
Copy link
Contributor

Thanks @apollo13. I made some changes based on your work.

I discovered that [up-switch] no longer works when all params are considered array fields. I have an idea for this, will work on this later.

@triskweline triskweline merged commit b12e699 into unpoly:master Jun 24, 2025
6 checks passed
@apollo13
Copy link
Contributor Author
apollo13 commented Jun 24, 2025 via email

@apollo13
Copy link
Contributor Author

Tested it now, works great!

@apollo13 apollo13 deleted the add-form-config-arrayfields branch June 25, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apollo13 @triskweline
0