Release test #15
Closed
Release test #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates build scripts, Rust imports/flags, async execution replacement, project editions, and packaging configurations for the upcoming release.
- Rename and relocate the WASM artifact in the npm build step
- Switch to new Rust edition (2024), update imports and use
execute_dxb_sync - Adjust Deno publish settings and add alt text to README image
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build-npm.ts | Updated source and destination paths for the .wasm file |
| rs-lib/src/runtime.rs | Changed with_is_end_of_scope to with_is_end_of_context |
| rs-lib/src/pointer.rs | Updated import path for Reference |
| rs-lib/src/network/com_interfaces/webrtc_js_interface.rs | Updated import path for Endpoint |
| rs-lib/src/lib.rs | Swapped to execute_dxb_sync, reorganized imports |
| rs-lib/datex-core | Bumped submodule commit |
| rs-lib/Cargo.toml | Bumped Rust edition to 2024 |
| .rustfmt.toml | Bumped Rust edition to 2024 |
| deno.json | Added publish exclude rules |
| README.md | Switched image sizing to width and added alt text |
Comments suppressed due to low confidence (4)
rs-lib/src/runtime.rs:172
- Confirm that
with_is_end_of_context(true)triggers the same intended behavior as the previouswith_is_end_of_scope(true), since this changes the semantic flag being set.
.with_is_end_of_context(true)
rs-lib/src/lib.rs:66
- [nitpick] After unwrapping the
Result, the code calls.unwrap()on theOption; consider using.expect("Execution returned no result")to provide a clearer panic message instead of a genericNoneunwrap.
let result = execute_dxb_sync(input).unwrap_or_else(|err| {
scripts/build-npm.ts:42
- Ensure that the build process actually outputs
datex_core_js.wasminstead of the previousdatex_core_js_bg.wasm, or adjust this path back to match the generated artifact.
"src/datex-core/datex_core_js.wasm",
deno.json:31
- [nitpick] Verify that the
"!"negate patterns inexcludework as intended for Deno's publish configuration, as this syntax may not match the expected glob rules.
"publish": {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.