add --timeline option to draw virtical line every 10/60 seconds #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thank you for the pr. First, it LGTM. However, ping timings for all targets are not the same, especially in not async mode (It can happen in async mode if there are too many targets). The attached screenshot presents this issue. So, I cannot merge this pr as is. But I understand your motivation. I will consider it. BTW, printing timestamp on the 3rd line looks good. If you extract it (shigechika@c3a3316#diff-4a173307c12a52d82e6ad896a4dedcfb3b98c2724f557579c73a309d49d04413R479-R482) and make a pr, I'd like to merge it soon. |
|
--timeline option is usefull with --async-mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed timeline for daily operation.
"--timeline" option is useful for debugging and snapshots sharing.
Thank you