8000 optimized DataPool node performance by makaveli2P · Pull Request #43 · urban-toolkit/curio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

optimized DataPool node performance #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

optimized DataPool node performance #43

merged 2 commits into from
Jul 4, 2025

Conversation

makaveli2P
Copy link
Contributor

Describe your changes

Optimization of DataPool node performance by implementing a preview system for table display. This reduces data transfer for the display portion of DataPool functionality, while interaction processing still requires full dataset transfer to frontend.

Scope of Changes:

  • Display Layer: Now uses preview data (first 100 rows) instead of full dataset for table rendering.
  • Interaction Layer: Unchanged, still transfers full dataset for interaction processing and node communication.
  • Performance Impact: Reduces data transfer for display purposes.

Note: This is a partial solution to issue #39. The complete solution would require moving interaction processing to the backend, which seemed too complex without having more clarity from the team. This change provides immediate performance improvement for display while preserving all existing functionality. I will be working on moving interaction processing to the backend and adding unit tests for DataPoolBox.tsx soon!

Issue resolved by this PR (if any)

Type of change (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other:

Parts of Curio impacted by this PR:

  • Frontend
  • Backend
  • Sandbox

Testing

  • Unit Tests

  • Manual Testing (please provide details below)

  • Verified table display shows identical appearance to before (first 100 rows)

  • Confirmed all interactions and node-to-node communication preserved

  • Ran the manual tests in /tests directory

Screenshots (if relevant)

Checklist (Check all that apply)

  • I have manually loaded each .json test from the tests/ folder into Curio, ran all the nodes one by one, and checked that they run without errors and give the expected results
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fabio-miranda
Copy link
Contributor

Thank you, this is really helpful. I will check and merge in a week or two!

@fabio-miranda fabio-miranda merged commit ec1c5ad into urban-toolkit:main Jul 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabio-miranda fabio-miranda fabio-miranda approved these changes

@GMMULLER GMMULLER Awaiting requested review from GMMULLER GMMULLER is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makaveli2P @fabio-miranda
0