10000 "Problems with Merging Data Cleaning Nodes by ShanmukhUpad · Pull Request #51 · urban-toolkit/curio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"Problems with Merging Data Cleaning Nodes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

"Problems with Merging Data Cleaning Nodes #51

wants to merge 6 commits into from

Conversation

ShanmukhUpad
Copy link

Describe your changes

Added comment on how some data cleaning nodes will give runtime errors if merged incorrectly

Issue resolved by this PR (if any)

Type of change (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other:

Parts of Curio impacted by this PR:

  • Frontend
  • Backend
  • Sandbox

Testing

  • Unit Tests
  • Manual Testing (please provide details below)

Screenshots (if relevant)

RedLightViolationMergeError

Checklist (Check all that apply)

  • I have manually loaded each .json test from the tests/ folder into Curio, ran all the nodes one by one, and checked that they run without errors and give the expected results
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ShanmukhUpad ShanmukhUpad force-pushed the my-feature branch 2 times, most recently from faf885f to 12c8517 Compare July 9, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabio-miranda fabio-miranda Awaiting requested review from fabio-miranda fabio-miranda is a code owner

@GMMULLER GMMULLER Awaiting requested review from GMMULLER GMMULLER is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShanmukhUpad @fabio-miranda
0