8000 Fix Data Export output error by Aarsh2101 · Pull Request #55 · urban-toolkit/curio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Data Export output error #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Aarsh2101
Copy link
Contributor
@Aarsh2101 Aarsh2101 commented Jul 9, 2025

Describe your changes

Added a conditional check in the validate_output function to allow DATA_EXPORT nodes to silently pass when no output is returned from the user code. Specifically, the function now checks whether data.get('dataType') is empty or None, and skips raising an exception in such cases.

Issue resolved by this PR (if any)

Type of change (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other:

Parts of Curio impacted by this PR:

  • Frontend
  • Backend
  • Sandbox

Testing

  • Unit Tests
  • Manual Testing (please provide details below)

Screenshots (if relevant)

Screenshot 2025-07-08 at 7 35 54 PM Screenshot 2025-07-08 at 7 36 07 PM

Checklist (Check all that apply)

  • I have manually loaded each .json test from the tests/ folder into Curio, ran all the nodes one by one, and checked that they run without errors and give the expected results
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fabio-miranda fabio-miranda merged commit 34dd3aa into urban-toolkit:main Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0