Subdivision Surfaces - Pyramids with Creases example #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
approved these changes
Sep 13, 2024
|
Just passing through to say that landing these assets would be much appreciated! However, I do notice that the sharpness values used are non-standard. The assets use values like 25 and 100 which are outside the expected range of 0..10 to match OpenSubdiv. These will be treated as infinitely sharp according to USD: https://github.com/PixarAnimationStudios/OpenUSD/blob/release/pxr/usd/usdGeom/mesh.cpp#L386 |
|
Thanks for the poke. @crydalch could you comment on the out of range values? perhaps an update is in order? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial subdivision surface test scene. This one has some pyramids with edge and corner creases.