8000 Add OpenPBR scene variants by theblackunknown · Pull Request #97 · usd-wg/assets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add OpenPBR scene variants #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add OpenPBR scene variants #97

wants to merge 1 commit into from

Conversation

theblackunknown
Copy link
@theblackunknown theblackunknown commented Jul 6, 2025 •
edited
Loading

Summary

This PR fixes #91 by adding a material_model variant set on various prims to select an OpenPBR surface shader instead of the existing surface shader.
We keep backward compatibility by setting material_model variants set to standard_surface to keep the legacy behavior and look.

For easy consumption a new "top layer" stage file standard_shader_ball_scene_openpbr.usda has been added.

Note that this PR keeps the current ways of specifying looks: when a MaterialX document was used, I have added another one for OpenPBR tagged with MaterialX v1.39, where UsdShade graphs were used I have simply added new nodes.
Ideally we should strive to create MaterialX document for mtlx nodegraphs so that MaterialX data versionning and upgrading cna be handled via usdMtlx.

Quick test of using standard_shader_ball_scene_openpbr.usda in Maya and trying some variants from example_material variant set
image

@theblackunknown theblackunknown changed the title Add "OpenPBR" scene variants Add OpenPBR scene variants Jul 6, 2025
@crydalch
Copy link
Contributor
crydalch commented Jul 7, 2025 •
edited
Loading

Thanks for starting this up, great start! Some thoughts:

  • We should be sure to name the variant "OpenPBR Surface" or "OpenPBRSurface" (i.e. we should include "surface" not just "OpenPBR")
  • I'm not sure how I feel about having a separate layer that just sets the shading variant? It's easy enough to switch variants in usdview, and I don't feel like there's a lot of benefit to using variants, if we start adding separate layers that only set variants.
  • I think having OpenPBR Surface be the default variant selection could makes sense; though it might be a bit premature, as mtlxstandardsurface is more widely supported to this point... Would be good to hear from others in the community on that point.
  • We should also probably increase the version as well in the readme, to 1.1

Just some thoughts, but thanks again for starting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt OpenPBR in StandardShaderBall scene's materials
2 participants
@theblackunknown @crydalch
0