USWDS: Replaced deprecated xlink:href code with recommended use of href #6165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
suggested changes
Oct 31, 2024
amyleadem
previously approved these changes
Nov 1, 2024
There was a problem hiding this comment.
This looks good. Thanks!
I successfully performed the following tests:
- Confirm all
xlink:hrefreferences have been updated tohref - Confirm icons still display as expected in Safari, Firefox, Chrome
Can you add a changelog PR for this change?
Additionally, can you update the PR description by adding a "Markup change" section with a note that says users should update their xlink:href references to href?
mahoneycm
reviewed
Nov 4, 2024
RachelCorsino
commented
Nov 5, 2024
mejiaj
reviewed
Nov 5, 2024
mejiaj
suggested changes
Nov 7, 2024
There was a problem hiding this comment.
@RachelCorsino some small issues related to previous merge conflicts. Can you take a look? Please reach out if anything is unclear.
eefebe2 to
bc7db26
Compare
mejiaj
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
No regressions found, sharing for awareness.
loader-icon-2024-11-12.at.9.51.13.AM.mov
mahoneycm
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All
xlink:hrefinstances have be replaced withhrefwithin the repo in order to account for the deprecation ofxlink:href.Breaking change
Indicate if this update is a breaking change with one of the following statements:
This is not a breaking change.
Related issue
Closes #6088
Related pull requests
USWDS-Site: Replaced deprecated xlink:href code with recommended use of href #2926
Preview link
Preview link:
USWDS Storybook Icon
Problem statement
The USWDS repository currently contains numerous instances of xlink:href, which is a deprecated attribute that may cause compatibility issues/errors.
Solution
The USWDSrepository has been updated to use the
hrefattribute instead of the deprecatedxlink:hrefattribute.Markup Change
Users should update their
xlink:hrefreferences to href.Testing and review
<use>no longer usesxlink:hrefand useshrefinstead when inspecting an icon