USWDS - [site-alert]: sync variants with alert #6425
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the "error", "warning", "success" style variants to
site-alert. These put it in sync with the availablealertstyles.Breaking change
This is not a breaking change.
Problem statement
I attempted to use the
.usa-site-alert--errorclass in my code and was met with an uncolored gray box with no icon. upon checking https://unpkg.com/browse/@uswds/uswds@3.11.0/dist/css/uswds.css and https://unpkg.com/browse/@uswds/uswds@3.11.0/packages/usa-site-alert/src/styles/_usa-site-alert.scss I realized it was because no such class existed.Solution
https://designsystem.digital.gov/components/alert/ and https://designsystem.digital.gov/components/site-alert/ being more in sync will cause less developer confusion and users will already be familiar with the styles.