-
Notifications
You must be signed in to change notification settings - Fork 44
Bump the androidx group with 6 updates #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps the androidx group with 6 updates: | Package | From | To | | --- | --- | --- | | androidx.test.espresso:espresso-core | `3.1.0` | `3.6.1` | | androidx.appcompat:appcompat | `1.3.0` | `1.7.1` | | androidx.recyclerview:recyclerview | `1.2.0` | `1.4.0` | | androidx.browser:browser | `1.3.0` | `1.8.0` | | androidx.constraintlayout:constraintlayout | `2.0.4` | `2.2.1` | | androidx.annotation:annotation | `1.2.0` | `1.9.1` | Updates `androidx.test.espresso:espresso-core` from 3.1.0 to 3.6.1 Updates `androidx.appcompat:appcompat` from 1.3.0 to 1.7.1 Updates `androidx.recyclerview:recyclerview` from 1.2.0 to 1.4.0 Updates `androidx.browser:browser` from 1.3.0 to 1.8.0 Updates `androidx.constraintlayout:constraintlayout` from 2.0.4 to 2.2.1 Updates `androidx.annotation:annotation` from 1.2.0 to 1.9.1 --- updated-dependencies: - dependency-name: androidx.test.espresso:espresso-core dependency-version: 3.6.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: androidx - dependency-name: androidx.appcompat:appcompat dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: androidx - dependency-name: androidx.recyclerview:recyclerview dependency-version: 1.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: androidx - dependency-name: androidx.browser:browser dependency-version: 1.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: androidx - dependency-name: androidx.constraintlayout:constraintlayout dependency-version: 2.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: androidx - dependency-name: androidx.annotation:annotation dependency-version: 1.9.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: androidx ... Signed-off-by: dependabot[bot] <support@github.com>
f9017af
to
0e7cc95
Compare
- Update Gradle wrapper to 8.13 for AGP 8.11.0 compatibility - Update compileSdk and targetSdk from 33 to 34 - Update AGP to 8.11.0 to match other dependencies - Add buildFeatures.buildConfig configuration - Disable proxy and add Gradle performance properties
- Revert to AGP 8.1.1 which works with SDK 33 - Downgrade androidx libraries that require newer SDK versions: - androidx.appcompat: 1.7.1 -> 1.6.1 - androidx.recyclerview: 1.4.0 -> 1.3.2 - androidx.browser: 1.8.0 -> 1.7.0 - androidx.constraintlayout: 2.2.1 -> 2.1.4 - androidx.annotation: 1.9.1 -> 1.7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Gradle wrapper, JVM settings, caching, build features, and bumps key AndroidX dependencies.
- Updated Gradle wrapper to 8.13
- Increased JVM heap/metaspace, enabled parallel builds, caching, and configuration cache
- Re-enabled
buildConfig
in module and bumped AndroidX dependencies (espresso, appcompat, recyclerview, browser, constraintlayout, annotation)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
File | Description |
---|---|
gradle/wrapper/gradle-wrapper.properties | Upgrade distributionUrl to Gradle 8.13 |
gradle.properties | Increase -Xmx , add MaxMetaspaceSize , parallel/caching, comment out proxy, remove default buildconfig |
app/build.gradle | Re-enable buildConfig and bump AndroidX versions |
Comments suppressed due to low confidence (1)
gradle/wrapper/gradle-wrapper.properties:3
- There's a leading space in the removed line; ensure the property lines keep consistent indentation/formatting.
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
app/build.gradle
Outdated
exclude group: 'com.android.support', module: 'support-annotations' | ||
exclude group: 'com.google.code.findbugs' | ||
}) | ||
testImplementation 'junit:junit:4.13.2' | ||
|
||
implementation 'androidx.appcompat:appcompat:1.3.0' | ||
implementation 'androidx.appcompat:appcompat:1.6.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The appcompat version (1.6.1) does not match the intended bump to 1.7.1 in the PR description; please update to 1.7.1.
implementation 'androidx.appcompat:appcompat:1.6.1' | |
implementation 'androidx.appcompat:appcompat:1.7.1' |
Copilot uses AI. Check for mistakes.
app/build.gradle
Outdated
implementation 'com.google.android.material:material:1.3.0' | ||
implementation 'androidx.recyclerview:recyclerview:1.2.0' | ||
implementation 'androidx.recyclerview:recyclerview:1.3.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recyclerview version (1.3.2) does not match the intended bump to 1.4.0; please update to 1.4.0.
implementation 'androidx.recyclerview:recyclerview:1.3.2' | |
implementation 'androidx.recyclerview:recyclerview:1.4.0' |
Copilot uses AI. Check for mistakes.
app/build.gradle
Outdated
implementation 'androidx.cardview:cardview:1.0.0' | ||
implementation 'androidx.browser:browser:1.3.0' | ||
implementation 'androidx.browser:browser:1.7.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The browser version (1.7.0) does not match the intended bump to 1.8.0; please update to 1.8.0.
implementation 'androidx.browser:browser:1.7.0' | |
implementation 'androidx.browser:browser:1.8.0' |
Copilot uses AI. Check for mistakes.
implementation 'androidx.palette:palette:1.0.0' | ||
implementation 'androidx.constraintlayout:constraintlayout:2.0.4' | ||
implementation 'androidx.constraintlayout:constraintlayout:2.1.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constraintlayout version (2.1.4) does not match the intended bump to 2.2.1; please update to 2.2.1.
implementation 'androidx.constraintlayout:constraintlayout:2.1.4' | |
implementation 'androidx.constraintlayout:constraintlayout:2.2.1' |
Copilot uses AI. Check for mistakes.
app/build.gradle
Outdated
implementation 'com.google.android.flexbox:flexbox:3.0.0' | ||
implementation "androidx.annotation:annotation:1.2.0" | ||
implementation "androidx.annotation:annotation:1.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The annotation version (1.7.1) does not match the intended bump to 1.9.1; please update to 1.9.1.
implementation "androidx.annotation:annotation:1.7.1" | |
implementation "androidx.annotation:annotation:1.9.1" |
Copilot uses AI. Check for mistakes.
gradle.properties
Outdated
@@ -13,7 +13,7 @@ | |||
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | |||
# org.gradle.parallel=true | |||
#Sat Mar 04 11:07:15 CST 2017 | |||
org.gradle.jvmargs=-Xmx1536M \ | |||
org.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=512m \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] For consistency with other JVM args, consider using uppercase -Xmx2048M
.
org.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=512m \ | |
org.gradle.jvmargs=-Xmx2048M -XX:MaxMetaspaceSize=512m \ |
Copilot uses AI. Check for mistakes.
gradle.properties
Outdated
# systemProp.http.proxyPort=6153 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] If this proxy setting is no longer needed, consider removing the commented line instead of retaining it.
# systemProp.http.proxyPort=6153 |
Copilot uses AI. Check for mistakes.
- androidx.appcompat: 1.7.1 -> 1.6.1 - androidx.recyclerview: 1.4.0 -> 1.3.2 - androidx.browser: 1.8.0 -> 1.7.0 - androidx.constraintlayout: 2.2.1 -> 2.1.4 - androidx.annotation: 1.9.1 -> 1.7.1 - androidx.test.espresso:espresso-core: 3.6.1 -> 3.5.1 These versions are compatible with compileSdk 34
- androidx.appcompat: 1.5.1 (between 1.3.0 and 1.7.1) - androidx.recyclerview: 1.3.0 (between 1.2.0 and 1.4.0) - androidx.browser: 1.5.0 (between 1.3.0 and 1.8.0) - androidx.annotation: 1.5.0 (between 1.2.0 and 1.9.1) These are newer than current main but still compatible with SDK 34
Bumps the androidx group with 6 updates:
3.1.0
3.6.1
1.3.0
1.7.1
1.2.0
1.4.0
1.3.0
1.8.0
2.0.4
2.2.1
1.2.0
1.9.1
Updates
androidx.test.espresso:espresso-core
from 3.1.0 to 3.6.1Updates
androidx.appcompat:appcompat
from 1.3.0 to 1.7.1Updates
androidx.recyclerview:recyclerview
from 1.2.0 to 1.4.0Updates
androidx.browser:browser
from 1.3.0 to 1.8.0Updates
androidx.constraintlayout:constraintlayout
from 2.0.4 to 2.2.1Updates
androidx.annotation:annotation
from 1.2.0 to 1.9.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions