-
Notifications
You must be signed in to change notification settings - Fork 8.9k
access log add detour tag #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi @fcying 你方便把pr在 https://github.com/v2fly/v2ray-core 重新发起吗,在那边我们可以跑一些自动测试 |
换新仓库了? 是要删了旧的fork, 然后重新fork 新的吗? 直接发起pr 看着有挺多冲突的 |
重新fork 提交上去了. 另外. 我用新仓库编译失败@_@ 新仓库的提交没测试过, 只是合了下.....这个是什么错误?
|
|
xiocode
pushed a commit
to going/v2ray-core
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1639
建了个全局的 chan AccessMessageChan
替换原先的
log.Record(&log.AccessMessage
, 改成把AccessMessage
放到chan
里, 在routedDispatch
里面加上detourTag
后打印.有几个位置没替换:
1> error 的打印
2> udp连接 的打印(看代码udp 连接后面没跑routedDispatch? 不是很确定 就没修改)
3>mux/server.go 里面的打印(不知道这个是做什么的, 不确定会不会跑routedDispatch)
效果