8000 Showing URL when opening browser by juliobguedes · Pull Request #1246 · vtex/toolbelt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Showing URL when opening browser #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Showing URL when opening browser #1246

wants to merge 3 commits into from

Conversation

juliobguedes
Copy link

What is the purpose of this pull request?

As requested in #1245, the goal of this PR is to display the URL that will be opened in the browser to allow the user to open it manually in case of errors.

What problem is this solving?

Some users using Unix distributions were not able to login using vtex login because the open and opn packages do not work properly in their OSs.

How should this be manually tested?

  1. Add the .vtex/dev/bin folder to the PATH, as mentioned in the CONTRIBUTING file;
  2. run yarn watch in the root folder of the repository
  3. run vtex-test login
  4. see the url

Screenshots or example usage

Screenshot 2025-04-30 at 15 27 40

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@juliobguedes juliobguedes self-assigned this Apr 30, 2025
@juliobguedes
Copy link
Author

WIP: Still adding tests

daniyelnnr
daniyelnnr approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@daniyelnnr daniyelnnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine here!

silvadenisaraujo
silvadenisaraujo approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@silvadenisaraujo silvadenisaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniyelnnr daniyelnnr daniyelnnr approved these changes

@silvadenisaraujo silvadenisaraujo silvadenisaraujo approved these changes

Assignees

@juliobguedes juliobguedes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliobguedes @daniyelnnr @silvadenisaraujo
0