8000 fix(until): cleanup at next tick to avoid memory leak by Gianthard-cyh · Pull Request #4039 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(until): cleanup at next tick to avoid memory leak #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix(until): cleanup at next tick to avoid memory leak #4039

merged 2 commits into from
Jul 17, 2024

Conversation

Gianthard-cyh
Copy link
Contributor
@Gianthard-cyh Gianthard-cyh commented Jun 13, 2024 •
edited by antfu
Loading

Before submitting the PR, please make sure you do the following

  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

call stop in until in nextTick() instead of immediatly to fix #4034
close #4034. close #3867

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 13, 2024
@Gianthard-cyh Gianthard-cyh changed the title fix(until): call stop() on next tick fix(until): call stop() at next tick Jun 13, 2024
@Gianthard-cyh
Copy link
Contributor Author

This may duplicate with #3867. But for diffrent purposes. I wonder whether calling nextTick() or setTimeout() (in #3867) is a better solution.

@Gianthard-cyh Gianthard-cyh marked this pull request as draft June 13, 2024 13:39
@antfu antfu marked this pull request as ready for review July 17, 2024 13:30
@antfu @delaneyb
chore: update
51303c9 
Co-authored-by: delaneyb <delaneyb@users.noreply.github.com>
@antfu antfu mentioned this pull request Jul 17, 2024
Closed
@antfu antfu changed the title fix(until): call stop() at next tick fix(until): cleanup at next tick to avoid memory leak Jul 17, 2024
@antfu antfu enabled auto-merge July 17, 2024 13:34
antfu
antfu previously approved these changes Jul 17, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2024
@antfu antfu disabled auto-merge July 17, 2024 13:34
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@antfu antfu merged commit 8a023fe into vueuse:main Jul 17, 2024
7 of 8 checks passed
@Gianthard-cyh Gianthard-cyh deleted the fix/until branch July 17, 2024 14:06
This was referenced Sep 7, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 15, 2024
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watchers generated by until are not "one time" as said in the documentation
2 participants
@Gianthard-cyh @antfu
0