8000 feat(useDraggable): add `buttons` option by DrJonki · Pull Request #4084 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(useDraggable): add buttons option #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2024
Merged

feat(useDraggable): add buttons option #4084

merged 2 commits into from
Jul 17, 2024

Conversation

DrJonki
Copy link
Contributor
@DrJonki DrJonki commented Jul 5, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

#3850 disabled the use of all but the left mouse button in useDraggable. This PR adds the possibility to configure a set of buttons that trigger the drag events.

Additional context

N/A

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2024
@antfu antfu enabled auto-merge July 17, 2024 13:04
@antfu antfu added this pull request to the merge queue Jul 17, 2024
Merged via the queue into vueuse:main with commit e9938ea Jul 17, 2024
8 checks passed
@renovate renovate bot mentioned this pull request Aug 20, 2024
Open
1 task
This was referenced Sep 7, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 15, 2024
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJonki @antfu
0