feat(useAsyncState): cancel previous promise and use latest promise #4797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evious ones will be canceled
|
Thanks for your PR, would you mind adding some unit tests? |
Thanks for the suggestion! I've added the unit tests and updated the PR. Please let me know if any further changes are needed. |
|
Based on testing, I found that by default, the result of a slower previous request might override the latest one. |
Signed-off-by: davidglezz <davidgg666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a “cancellable” parameter to ensure that only the latest Promise takes effect, canceling the previous ones. The Promise can also be manually canceled by calling cancel().