8000 fix(useTransition): prevent runtime error when source is not number o… by Unknown51335 · Pull Request #4815 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(useTransition): prevent runtime error when source is not number o… #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(useTransition): prevent runtime error when source is not number o… #4815

wants to merge 1 commit into from

Conversation

Unknown51335
Copy link

…r number[]

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Fixes #4814

This PR fixes a potential runtime error in useTransition when the source is not a number or array of numbers.

Currently, passing a string or other unsupported type as source will result in:

TypeError: v.map is not a function
This can crash the application or prevent rendering when unexpected types are passed in.

Additional context

The fix introduces a simple type check to ensure the value is either:

  • a single number, or

  • an array (e.g., number[] or MaybeRef[])

Otherwise, it falls back to a safe default (0), avoiding the .map() call on unsupported types.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 12, 2025
@9romise
Copy link
Contributor
9romise commented Jun 12, 2025

Actually, I think throwing an error here is expected because this will remind you of the reason.

From what I've seen in the documentation, the first argument to useTransition is of type MaybeRefOrGetter<number> or MaybeRefOrGetter<number>[], and I don't think it should handle cases outside of these two types. Doing handling here will cause harder to troubleshoot non-expected cases.

According to your description, you defined the data type wrong and need to fix it.

@Unknown51335
Copy link
Author

@9romise Thank you for your reply — I completely agree with your point. You're right that my commit could hide the real issue and make debugging harder.

But I noticed that other functions like useCountdown and useCounter don’t crash the app when they receive unexpected input. I wonder if this could be an area for improvement in useTransition?

If you think it makes sense, I’d be happy to revise my code to improve the robustness of useTransition without compromising the clarity of the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG | useTransition | passing an unsupported type will result in a runtime exception
2 participants
@Unknown51335 @9romise
0