8000 feat(useJwt)!: upgrade `jwt-decode` to v4 by root5427 · Pull Request #3510 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(useJwt)!: upgrade jwt-decode to v4 #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 12, 2024
Merged

feat(useJwt)!: upgrade jwt-decode to v4 #3510

merged 6 commits into from
Jun 12, 2024

Conversation

root5427
Copy link
Contributor
@root5427 root5427 commented Oct 28, 2023 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Renamed jwt_decode to jwtDecode for compatibility with jwt-decode package's latest release

🤖 Generated by Copilot at 3a9fe5d

Updated the useJwt integration to use a newer API of jwt-decode. Fixed the import and usage of jwtDecode in packages/integrations/useJwt/index.ts.

🤖 Generated by Copilot at 3a9fe5d

  • Replace deprecated default export of jwt-decode with named export jwtDecode (link,link)

@root5427 root5427 closed this Oct 29, 2023
@root5427 root5427 deleted the patch-2 branch October 29, 2023 20:16
@root5427 root5427 restored the patch-2 branch October 29, 2023 20:17
@root5427 root5427 reopened this Oct 29, 2023
@root5427 root5427 force-pushed the patch-2 branch 3 times, most recently from c717906 to f4310f6 Compare November 16, 2023 09:24
@TheVaan
Copy link
TheVaan commented Feb 18, 2024

Please merge this PR, as it upgrades jwt-decode to latest version! The latest version has several internal improvements in bundle size etc.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2024
@root5427
fix(useJwt)!: rename jwt_decode to jwtDecode
6c196b4 
Renamed `jwt_decode` to `jwtDecode` for compatibility with `jwt-decode` package's [latest release](https://github.com/auth0/jwt-decode/releases/tag/v4.0.0)

Solves vueuse#3508
@antfu antfu added this to the 11.0 milestone Jun 12, 2024
@antfu antfu changed the title fix(useJwt)!: rename jwt_decode to jwtDecode feat(useJwt)!: upgrade jwt-decode to v4 Jun 12, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 12, 2024
antfu
antfu previously approved these changes Jun 12, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 12, 2024
@antfu antfu enabled auto-merge June 12, 2024 11:55
@antfu antfu added this pull request to the merge queue Jun 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 12, 2024
@antfu antfu merged commit 9037d60 into vueuse:main Jun 12, 2024
7 checks passed
This was referenced Sep 7, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 15, 2024
Closed
@gn00029914 gn00029914 mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEK58 JEK58 JEK58 approved these changes

@matdudek matdudek matdudek approved these changes

@ax-mjones ax-mjones ax-mjones approved these changes

@antfu antfu antfu left review comments

Assignees
No one assigned
Labels
BREAKING CHANGE lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

useJwt 不支持 jwt-decode 4.0（useJwt does not support jwt-decode 4.0）
6 participants
@root5427 @TheVaan @antfu @JEK58 @matdudek @ax-mjones
0