8000 fix(useScrollLock): initialOverflow is not working by BJ0815 · Pull Request #3798 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(useScrollLock): initialOverflow is not working #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2024
Merged

fix(useScrollLock): initialOverflow is not working #3798

merged 4 commits into from
Feb 27, 2024

Conversation

BJ0815
Copy link
Contributor
@BJ0815 BJ0815 commented Feb 20, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR makes a change to ensure that the initial overflow value is correctly saved.

Additionally, a test case has been added to cover this change.

Additional context

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. direction: approved The direction of feature/change is approved by the team. May require some small changes. vue: upstream labels Feb 20, 2024
@antfu antfu removed direction: approved The direction of feature/change is approved by the team. May require some small changes. vue: upstream labels Feb 21, 2024
@antfu antfu changed the title fix(useScrollLock)：initialOverflow is not working fix(useScrollLock): initialOverflow is not working Feb 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2024
@antfu antfu enabled auto-merge February 27, 2024 04:27
@antfu antfu added this pull request to the merge queue Feb 27, 2024
Merged via the queue into vueuse:main with commit 74e86b5 Feb 27, 2024
@BJ0815 BJ0815 deleted the useScrollLock branch March 1, 2024 16:05
@ChristophJeworutzki
Copy link

Thank you for this PR!

I've come across a little hiccup since this update.

It seems that in certain scenarios, overflow: hidden persists or is reapplied after setting scrollLock to false

I have a feeling this might be tied to a race condition, where overflow: hidden is being incorrectly set as the "initial state."

Just wanted to bring it to your attention!

Thanks again for all your work on this!

@ChristophJeworutzki ChristophJeworutzki mentioned this pull request Mar 5, 2024
Closed
noook pushed a commit to noook/vueuse that referenced this pull request Mar 26, 2024
@BJ0815 @noook
fix(useScrollLock): initialOverflow is not working (vueuse#3798)
371e8da
@renovate renovate bot mentioned this pull request Apr 16, 2024
Open
1 task
This was referenced May 25, 2024
Open
Open
@abdullahkabakk abdullahkabakk mentioned this pull request Jun 17, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Jun 18, 2024
Open
This was referenced Jul 3, 2024
Open
Open
This was referenced Jul 24, 2024
Open
Open
@Samad2011s Samad2011s mentioned this pull request Jul 28, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 30, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
Open
Open
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
This was referenced Sep 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BJ0815 @ChristophJeworutzki @antfu
0