10000 Create gambia.py by yashwanth2307 · Pull Request #2447 · vacanza/holidays · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Create gambia.py #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Create gambia.py #2447

wants to merge 1 commit into from

Conversation

yashwanth2307
Copy link
@yashwanth2307 yashwanth2307 commented Apr 8, 2025 •
edited
Loading

Proposed change

Your PR description goes here.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

I have added the calendar for gambia

holidays/countries/gambia.py

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 8, 2025 •
edited
Loading

Summary by CodeRabbit

  • New Features
    • Introduced a new capability to retrieve and display public holidays in The Gambia for any specified year.
    • Provides computed dates for fixed and variable holidays, ensuring accurate holiday information with robust error handling and fallback calculations.

Walkthrough

A new Python module has been added to manage public holidays in The Gambia. This module defines functions to retrieve holidays for a specified year, using the holidays library with a fallback to manually computed holiday dates in case of errors. The file includes helper functions to calculate fixed-date holidays, determine Easter with a simplified algorithm, and approximate Islamic holidays via the hijri_converter library. It also incorporates error handling and a main block to display holiday lists for multiple years.

Changes

File Change Summary
holidays/.../gambia.py Introduced new module with functions: get_gambia_holidays(year), _get_manual_gambia_holidays(year), and _calculate_easter(year); adds holiday retrieval with fallback, date computations for fixed, Christian, and Islamic holidays, and includes error handling and a main execution block.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai[bot]
coderabbitai bot reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f3936c and 0e4f03b.

📒 Files selected for processing (1)
  • holidays/countries/gambia.py (1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
holidays/countries/gambia.py (1)
holidays/holiday_base.py (1)
  • update (1249-1275)
🪛 Ruff (0.8.2)
holidays/countries/gambia.py

13-13: print found

Remove print

(T201)

51-51: print found

Remove print

(T201)

79-79: print found

Remove print

(T201)

81-81: print found

Remove print

(T201)

84-84: print found

Remove print

(T201)

86-86: print found

Remove print

(T201)

87-87: print found

Remove print

(T201)

88-88: print found

Remove print

(T201)

88-88: Line too long (101 > 99)

(E501)

89-89: print found

Remove print

(T201)

89-89: Line too long (111 > 99)

(E501)

90-90: print found

Remove print

(T201)

90-90: Line too long (176 > 99)

(E501)

90-90: No newline at end of file

Add trailing newline

(W292)

🔇 Additional comments (1)
holidays/countries/gambia.py (1)

55-67: Good implementation of the Easter calculation algorithm.

The Easter calculation function is well-implemented with proper error handling and a docstring.

@KJhellico
Copy link
Collaborator

@yashwanth2307, I recommend you to look at the code of other countries to learn about the code style and features used in the project.

@KJhellico KJhellico marked this pull request as draft April 8, 2025 16:18
@arkid15r
Copy link
Collaborator
arkid15r commented Apr 8, 2025

Please take a look at some recently merged PR examples:

@arkid15r arkid15r closed this Apr 8, 2025
@arkid15r arkid15r mentioned this pull request Apr 9, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashwanth2307 @KJhellico @arkid15r
0