8000 Refactor Trinidad and Tobago holidays by PPsyrius · Pull Request #2617 · vacanza/holidays · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor Trinidad and Tobago holidays #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Refactor Trinidad and Tobago holidays #2617

merged 1 commit into from
Jun 10, 2025

Conversation

PPsyrius
Copy link
Collaborator
@PPsyrius PPsyrius commented Jun 10, 2025 •
edited
Loading

Proposed change

Remove the unnecessary dts_observed.add( ... ) assignments for Good Friday and Easter Monday as discovered during a code review discussion with @Roshan-1024 for #2609 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 10, 2025 •
edited
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of Good Friday and Easter Monday holidays for Trinidad and Tobago, ensuring accurate holiday observance.

Walkthrough

The code updates the handling of Good Friday and Easter Monday in Trinidad and Tobago’s holiday population logic. These holidays are now added without tracking their dates in the set used for observed holidays. All other holiday addition and observed date logic remains unchanged.

Changes

Files Change Summary
holidays/countries/trinidad_and_tobago.py Stopped adding Good Friday and Easter Monday dates to the observed holidays set.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b4f02b and 30c1ee7.

📒 Files selected for processing (1)
  • holidays/countries/trinidad_and_tobago.py (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
holidays/countries/trinidad_and_tobago.py (1)
holidays/groups/christian.py (2)
  • _add_good_friday (308-317)
  • _add_easter_monday (259-268)
⏰ Context from checks skipped due to timeout of 300000ms (1)
  • GitHub Check: Build distribution
🔇 Additional comments (3)
holidays/countries/trinidad_and_tobago.py (3)

101-101: Good optimization removing unnecessary observed date tracking.

Since Good Friday is always on Friday by definition, it doesn't need observed holiday logic applied.

104-104: Correct optimization for Easter Monday as well.

Easter Monday is always on Monday by definition, so observed date tracking is unnecessary.

94-144: Implementation is consistent and well-reasoned.

The selective removal of observed date tracking only for inherently weekday holidays maintains consistency with the overall observed holiday logic.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link
codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b4f02b) to head (30c1ee7).
Report is 6 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          229       229           
  Lines        14571     14571           
  Branches      2039      2039           
=========================================
  Hits         14571     14571

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KJhellico
Copy link
Collaborator

Look at my comment here about this case. However, not including Good Friday and Easter Monday in dts_observed doesn't cause any loss in the final holidays list, as the date will still be processed.

@KJhellico
Copy link
Collaborator

But if we implement holiday as separate object in v1 (which I hope for), then this may require changes again...

KJhellico
KJhellico approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator
@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

arkid15r
arkid15r reviewed Jun 10, 2025
View reviewed changes
Copy link
Collaborator
@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Jun 10, 2025
Merged via the queue into vacanza:dev with commit ed5e321 Jun 10, 2025
33 checks passed
@PPsyrius PPsyrius deleted the TT_optimized branch June 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PPsyrius @KJhellico @arkid15r
0