8000 Adding KEYINFO command to find out keys that have large number of elements by otheng03 · Pull Request #1151 · valkey-io/valkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding KEYINFO command to find out keys that have large number of elements #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from
Open

Adding KEYINFO command to find out keys that have large number of elements #1151

wants to merge 3 commits into from

Conversation

otheng03
Copy link
Contributor
@otheng03 otheng03 commented Oct 11, 2024 •
edited
Loading

ISSUE LINK: #1827

  • Add two new parameters to valkey.conf:
    • keyinfo-num-elements-larger-than
    • keyinfo-large-num-elements-max-len
  • Implement three new commands:
    • KEYINFO GET <count> MANY_ELEMENTS
    • KEYINFO LEN MANY_ELEMENTS
    • KEYINFO RESET MANY_ELEMENTS

@otheng03 otheng03 force-pushed the bigkeylog branch 2 times, most recently from 97e7b68 to e19f7ee Compare October 11, 2024 15:34
@otheng03 otheng03 mentioned this pull request Mar 6, 2025
Open
This was referenced Apr 3, 2025
Closed
Closed
@otheng03 otheng03 force-pushed the bigkeylog branch 2 times, most recently from 6574313 to deb21af Compare April 8, 2025 18:48
@otheng03 otheng03 changed the title Adding bigkeylog commands to find out bigkeys Adding KEYINFO command to find out keys that have large number of elements Apr 8, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.56204% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (2d200df) to head (23a9c40).

Files with missing lines Patch % Lines
src/keyinfo.c 72.72% 24 Missing ⚠️
src/config.c 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #1151      +/-   ##
============================================
+ Coverage     71.02%   71.07%   +0.05%     
============================================
  Files           123      124       +1     
  Lines         66116    66245     +129     
============================================
+ Hits          46956    47082     +126     
- Misses        19160    19163       +3
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)
src/db.c 89.58% <100.00%> (+<0.01%) ⬆️
src/server.c 87.94% <100.00%> (+0.03%) ⬆️
src/server.h 100.00% <ø> (ø)
src/t_hash.c 96.23% <100.00%> (-0.11%) ⬇️
src/t_list.c 92.96% <100.00%> (+0.08%) ⬆️
src/t_set.c 97.86% <100.00%> (+0.35%) ⬆️
src/t_stream.c 93.18% <100.00%> (+<0.01%) ⬆️
src/t_string.c 96.79% <100.00%> (+0.01%) ⬆️
src/t_zset.c 96.77% <100.00%> (+0.01%) ⬆️
... and 2 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@otheng03 otheng03 force-pushed the bigkeylog branch 4 times, most recently from 4949a98 to 47c89bd Compare April 16, 2025 14:45
otheng03
otheng03 commented Apr 23, 2025
View reviewed changes
otheng03
otheng03 commented Apr 23, 2025
View reviewed changes
@otheng03 otheng03 force-pushed the bigkeylog branch 2 times, most recently from 53e94d4 to 0f13625 Compare April 28, 2025 14:39
@otheng03
Initial implementation of keyinfo mane-elements
2dac060 
Signed-off-by: otheng03 <qnade@naver.com>
otheng03 added 2 commits April 29, 2025 09:17
@otheng03
Merge branch 'unstable' into bigkeylog
498d138 
Signed-off-by: otheng <qnade@naver.com>
@otheng03
Update keyinfo.c
23a9c40 
Signed-off-by: otheng <qnade@naver.com>
@otheng03 otheng03 marked this pull request as ready for review April 29, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@otheng03
0