Add sentinel_total_tilt to sentinel INFO sentinel #1904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1904 +/- ##
============================================
+ Coverage 71.00% 71.03% +0.02%
============================================
Files 123 123
Lines 65675 65706 +31
============================================
+ Hits 46631 46671 +40
+ Misses 19044 19035 -9
🚀 New features to boost your workflow:
|
|
I do not understand why admin need to know the total number of the tilt, tilt is only a status, it can be entered or exited. |
|
@hwware When sentinel enters titl, it will affect the cluster's failover. If the number of entries is too more, in general may need to rebalance the sentinel. |
kukey
approved these changes
Apr 1, 2025
hwware
approved these changes
Apr 3, 2025
|
Please sign your DCO, Thanks |
enjoy-binbin
reviewed
Apr 7, 2025
|
@valkey-io/core-team Looks like a minor optimization for sentinel, please approval or comment. |
Signed-off-by: carlosfu <carlosfu@163.com>
Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: carlosfu <carlosfu@163.com>
|
@carlosfu Please update the updated-doc PR here, and we will merge this PR, Thanks |
|
zuiderkwast
approved these changes
Apr 17, 2025
zuiderkwast
added a commit
to valkey-io/valkey-doc
that referenced
this pull request
Apr 17, 2025
Documentation for valkey-io/valkey#1904 --------- Signed-off-by: carlosfu <carlosfu@163.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition. --------- Signed-off-by: carlosfu <carlosfu@163.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Nitai Caro <caronita@amazon.com>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition. --------- Signed-off-by: carlosfu <carlosfu@163.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
nitaicaro
pushed a commit
to nitaicaro/valkey
that referenced
this pull request
Apr 22, 2025
it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition. --------- Signed-off-by: carlosfu <carlosfu@163.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
hwware
pushed a commit
to wuranxx/valkey
that referenced
this pull request
Apr 24, 2025
it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition. --------- Signed-off-by: carlosfu <carlosfu@163.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: hwware <wen.hui.ware@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition.