Fix the build on less common platforms in zmalloc.c #1922
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional. Fixes valkey-io#1916 Signed-off-by: Nathan Scott <nathans@redhat.com>
8000
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1922 +/- ##
============================================
+ Coverage 71.02% 71.05% +0.02%
============================================
Files 123 123
Lines 65683 65683
============================================
+ Hits 46653 46668 +15
+ Misses 19030 19015 -15
🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Apr 7, 2025
zuiderkwast
approved these changes
Apr 7, 2025
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional. Fixes valkey-io#1916 Signed-off-by: Nathan Scott <nathans@redhat.com>
murphyjacob4
pushed a commit
to murphyjacob4/valkey
that referenced
this pull request
Apr 18, 2025
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional. Fixes valkey-io#1916 Signed-off-by: Nathan Scott <nathans@redhat.com>
murphyjacob4
pushed a commit
to murphyjacob4/valkey
that referenced
this pull request
Apr 18, 2025
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional. Fixes valkey-io#1916 Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
murphyjacob4
pushed a commit
to murphyjacob4/valkey
that referenced
this pull request
Apr 23, 2025
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional. Fixes valkey-io#1916 Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
zuiderkwast
pushed a commit
that referenced
this pull request
Apr 23, 2025
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional. Fixes #1916 Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a mismatched type declaration for the used_memory_thread pointer into the used_memory_thread_padded array (global scope) - in the less used else branch of a cpp platform conditional.
Fixes #1916