blocking client followup fix related to log_req_res #1989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yairgott <yairgott@gmail.com>
Signed-off-by: yairgott <yairgott@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1989 +/- ##
============================================
+ Coverage 71.01% 71.03% +0.01%
============================================
Files 123 123
Lines 66033 66033
============================================
+ Hits 46895 46904 +9
+ Misses 19138 19129 -9
🚀 New features to boost your workflow:
|
murphyjacob4
pushed a commit
to murphyjacob4/valkey
that referenced
this pull request
Apr 23, 2025
See valkey-io#1819 (comment) Verified the fix by: 1. Build: `make SERVER_CFLAGS='-Werror -DLOG_REQ_RES' -j10` 2. Running module api tests: `CFLAGS='-Werror' ./runtest-moduleapi --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs` --------- Signed-off-by: yairgott <yairgott@gmail.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
zuiderkwast
pushed a commit
that referenced
this pull request
Apr 23, 2025
See #1819 (comment) Verified the fix by: 1. Build: `make SERVER_CFLAGS='-Werror -DLOG_REQ_RES' -j10` 2. Running module api tests: `CFLAGS='-Werror' ./runtest-moduleapi --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs` --------- Signed-off-by: yairgott <yairgott@gmail.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
hwware
pushed a commit
to wuranxx/valkey
that referenced
this pull request
Apr 24, 2025
See valkey-io#1819 (comment) Verified the fix by: 1. Build: `make SERVER_CFLAGS='-Werror -DLOG_REQ_RES' -j10` 2. Running module api tests: `CFLAGS='-Werror' ./runtest-moduleapi --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs` --------- Signed-off-by: yairgott <yairgott@gmail.com> Signed-off-by: hwware <wen.hui.ware@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1819 (comment)
Verified the fix by:
make SERVER_CFLAGS='-Werror -DLOG_REQ_RES' -j10CFLAGS='-Werror' ./runtest-moduleapi --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs