Add output buffer limiting for unauthenticated clients #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a mechanism to track client authentication state with a new ever_authenticated flag. It refactors client authentication handling by adding a clientSetUser function that properly sets both the authenticated and ever_authenticated flags. The implementation limits output buffer size for clients that have never been authenticated. Added tests to verify the output buffer limiting behavior for unauthenticated clients. Signed-off-by: Uri Yagelnik <uriy@amazon.com>
zuiderkwast
approved these changes
Apr 23, 2025
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
approved these changes
Apr 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.1 #1994 +/- ##
==========================================
+ Coverage 71.03% 71.06% +0.03%
==========================================
Files 123 123
Lines 65787 65797 +10
==========================================
+ Hits 46734 46761 +27
+ Misses 19053 19036 -17
🚀 New features to boost your workflow:
|
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
13 tasks
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Apr 25, 2025
This commit introduces a mechanism to track client authentication state with a new `ever_authenticated` flag. It refactors client authentication handling by adding a `clientSetUser` function that properly sets both the `authenticated` and `ever_authenticated` flags. The implementation limits output buffer size for clients that have never been authenticated. Added tests to verify the output buffer limiting behavior for unauthenticated clients. --------- Signed-off-by: Uri Yagelnik <uriy@amazon.com> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a mechanism to track client authentication state with a new
ever_authenticatedflag. It refactors client authentication handling by adding aclientSetUserfunction that properly sets both theauthenticatedandever_authenticatedflags.The implementation limits output buffer size for clients that have never been authenticated.
Added tests to verify the output buffer limiting behavior for unauthenticated clients.