Log cluster state periodically to capture transient state for debuggability #2011
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debugability Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2011 +/- ##
============================================
- Coverage 71.01% 70.99% -0.03%
============================================
Files 123 123
Lines 66033 66125 +92
============================================
+ Hits 46892 46944 +52
- Misses 19141 19181 +40
🚀 New features to boost your workflow:
|
madolson
reviewed
Apr 28, 2025
| sds cluster_info = genClusterInfoString(); | ||
| sds cluster_nodes = clusterGenNodesDescription(NULL, 0, 0); | ||
|
|
||
| sds infostring = sdscatprintf(sdsempty(), "\r\n# Cluster info\r\n"); |
There was a problem hiding this comment.
New lines break log parsing. If someone turns on for some reason, it should still be "valid" log lines. I'm OK logging the state, but I don't think it should just be verbatim the info fields.
There was a problem hiding this comment.
Interesting. So, it's an exception for crash report to have new lines?
There was a problem hiding this comment.
@madolson and I discussed offline. We discussed we can have a single log line with information around failed nodes rather than all the nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logs CLUSTER INFO / CLUSTER NODES output every 5 seconds to the log file for verbose/debug loglevel mode.
Certain times few nodes are not in convergence with the entire cluster and there are no logs captured about the divergence. This logging could help us better analyze in test setup where we can aggressively log more cluster information.