8000 Flip pfail flag while marking node as failed by hpatro · Pull Request #2012 · valkey-io/valkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Flip pfail flag while marking node as failed #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Flip pfail flag while marking node as failed #2012

wants to merge 1 commit into from

Conversation

hpatro
Copy link
Collaborator
@hpatro hpatro commented Apr 26, 2025

No description provided.

@hpatro
Flip pfail flag while marking node as failed
72ce517 
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
@codecov Codecov
Copy link
codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (0b94ca6) to head (72ce517).
Report is 10 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #2012      +/-   ##
============================================
- Coverage     71.01%   71.00%   -0.01%     
============================================
  Files           123      123              
  Lines         66033    66115      +82     
============================================
+ Hits          46892    46945      +53     
- Misses        19141    19170      +29
Files with missing lines Coverage Δ
src/cluster_legacy.c 86.41% <100.00%> (+0.32%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zuiderkwast
zuiderkwast reviewed Apr 27, 2025
View reviewed changes
Copy link
Contributor
@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Can this difference be observed by users at all?

@hpatro
Copy link
< B6AE /details-menu>
Collaborator Author
hpatro commented Apr 28, 2025

Why?

Can this difference be observed by users at all?

As far as I understand, the cluster node state transition from PFAIL to FAIL and both of these are mutually exclusive and shouldn't exist together. So, I think finding the below response under CLUSTER NODES is incorrect.

> ./valkey-cli cluster nodes | grep fail?
511676acd16696d5b8767aa6c4a8ba54c69b70a0 :0@0 master,fail?,fail,noaddr - 1745372213541 0 1993 disconnected

@sarthakaggarwal97
Copy link
Contributor

looks like we do a similar change here in markNodeAsFailingIfNeeded. It is called in clusterCron and through cluster gossip.

@hpatro hpatro requested a review from madolson April 29, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast left review comments

@enjoy-binbin enjoy-binbin Awaiting requested review from enjoy-binbin

@madolson madolson Awaiting requested review from madolson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpatro @sarthakaggarwal97 @zuiderkwast
0