8000 Compile with -Wundef by zuiderkwast · Pull Request #2025 · valkey-io/valkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Compile with -Wundef #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: unstable
Choose a base branch
from
Open

Conversation

zuiderkwast
Copy link
Contributor

This catches spelling errors in macros, like #if MACCRO.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Apr 29, 2025
Copy link
codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (25ef0b3) to head (80775de).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2025      +/-   ##
============================================
- Coverage     70.99%   70.98%   -0.02%     
============================================
  Files           123      123              
  Lines         66116    66135      +19     
============================================
+ Hits          46942    46944       +2     
- Misses        19174    19191      +17     
Files with missing lines Coverage Δ
src/crcspeed.c 37.57% <ø> (ø)
src/debug.c 53.46% <ø> (ø)
src/rdma.c 100.00% <ø> (ø)
src/rio.c 84.83% <ø> (ø)
src/sentinel.c 0.00% <ø> (ø)
src/setproctitle.c 76.19% <ø> (ø)
src/tls.c 100.00% <ø> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member
@rjd15372 rjd15372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast
Copy link
Contributor Author

@rjd15372 Don't approve yet. 😂 Need to fix a lot of undefined macros on various platforms first.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast
Copy link
Contributor Author

@lipzhu Sorry, I should have mentioned I started this.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast marked this pull request as ready for review April 30, 2025 23:28
@zuiderkwast zuiderkwast requested a review from lipzhu April 30, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0