8000 fix(ci): e2e dd logs failure by pront · Pull Request #23038 · vectordotdev/vector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ci): e2e dd logs failure #23038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

B 10000 y clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 14, 2025
Merged

fix(ci): e2e dd logs failure #23038

merged 10 commits into from
May 14, 2025

Conversation

pront
Copy link
Member
@pront pront commented May 13, 2025

Summary

Changes:

  • Now dd_url is specified in DD agent config
  • Fakeintake image was updated to a newer version
  • The E2E datadog logs test is more robust (using retries instead of sleeping once)
  • The scripts/int-e2e-test.sh can now be used for local iterations
  • Improves debug messages, if this fails again we will have better hints

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Run the following on my machine and on an EC2 instance:

TEST_DATADOG_API_KEY=X RUST_VERSION=1.85 /Users/pavlos.rontidis/CLionProjects/vector/scripts/int-e2e-test.sh e2e datadog-logs

Result:

   Compiling vector v0.47.0 (/home/vector)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 27.53s
    Starting 1 test across 1 binary (2 skipped; run ID: 4036e860-f594-4709-a392-67f785ec0b5c, nextest profile: default)
       START             vector::e2e datadog::logs::validate

running 1 test
2025-05-14T18:06:27.093931Z  INFO e2e::datadog::logs: getting log payloads from agent-only pipeline
2025-05-14T18:06:27.154527Z  INFO e2e::datadog::logs: log events received: 1000
2025-05-14T18:06:27.154638Z  INFO e2e::datadog::logs: getting log payloads from agent-vector pipeline
2025-05-14T18:06:27.209538Z  INFO e2e::datadog::logs: log events received: 1000
test datadog::logs::validate ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.12s

        PASS [   0.137s] vector::e2e datadog::logs::validate
        SKIP [         ] vector::e2e datadog::metrics::test_decompress_payload_zstd
        SKIP [         ] vector::e2e datadog::metrics::validate
------------
     Summary [   0.138s] 1 test run: 1 passed, 2 skipped
+ RET=0
+ cargo vdev -v e2e stop -a datadog-logs
Executing: "docker" "ps" "-a" "--format" "{{.Names}} {{.State}}"
Executing: "docker" "rm" "--force" "--volumes" "vector-test-runner-1.85"
Stopping service environment
Executing: cd "/home/ubuntu/vector/scripts/e2e/datadog-logs" && DOCKER_SOCKET="/var/run/docker.sock" RUST_VERSION="1.85" VECTOR_NETWORK="vector-integration-tests-datadog-logs" agent_version="latest" "docker" "compose" "--file" "/home/ubuntu/vector/scripts/e2e/datadog-logs/compose.yaml" "down" "--timeout" "0" "--volumes"
  in working directory "/home/ubuntu/vector/scripts/e2e/datadog-logs"
  $DOCKER_SOCKET="/var/run/docker.sock"
  $RUST_VERSION="1.85"
  $VECTOR_NETWORK="vector-integration-tests-datadog-logs"
  $agent_version="latest"
WARN[0000] The "CONFIG_AGENT_VERSION" variable is not set. Defaulting to a blank string.
WARN[0000] The "CONFIG_AGENT_VERSION" variable is not set. Defaulting to a blank string.
WARN[0000] The "CONFIG_VECTOR_IMAGE" variable is not set. Defaulting to a blank string.
WARN[0000] /home/ubuntu/vector/scripts/e2e/datadog-logs/compose.yaml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion
[+] Running 7/7
 ✔ Container datadog-logs-log_generator-1         Removed                                                                                                                     0.0s
 ✔ Container datadog-logs-datadog-agent-vector-1  Removed                                                                                                                     0.2s
 ✔ Container datadog-logs-datadog-agent-1         Removed                                                                                                                     0.2s
 ✔ Container datadog-logs-vector-1                Removed                                                                                                                     0.2s
 ✔ Container datadog-logs-fakeintake-agent-1      Removed                                                                                                                     0.2s
 ✔ Container datadog-logs-fakeintake-vector-1     Removed                                                                                                                     0.1s
 ✔ Volume datadog-logs_log_path                   Removed                                                                                                                     0.0s
+ [[ -n '' ]]
+ exit 0

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label May 13, 2025
pront

This comment was marked as outdated.

@pront pront changed the title wip fix(ci): e2e dd logs failure May 13, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 13, 2025
@pront pront force-pushed the pront/fix-e2e-dd-logs branch from 081aa67 to b522745 Compare May 13, 2025 14:24
pront

This comment was marked as outdated.

@datadog-vectordotdev
Copy link
datadog-vectordotdev bot commented May 13, 2025

Datadog Report

Branch report: pront/fix-e2e-dd-logs
Commit report: f055f61
Test service: vector

✅ 0 Failed, 8 Passed, 0 Skipped, 25.45s Total Time

pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from ef4fc9d to 463d266 Compare May 13, 2025 18:03
pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from 463d266 to 35207ff Compare May 13, 2025 18:07
pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from 35207ff to 5ac1977 Compare May 13, 2025 18:15
pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from 5ac1977 to b92e7e4 Compare May 13, 2025 19:30
@pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from a5efc71 to 2766b67 Compare May 13, 2025 19:49
pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from ef7198f to 59c0ab0 Compare May 14, 2025 15:24
pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

@pront pront force-pushed the pront/fix-e2e-dd-logs branch from 4e07efd to 414690d Compare May 14, 2025 16:50
pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

Copy link
Member Author
@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-e2e-datadog-logs

@pront pront force-pushed the pront/fix-e2e-dd-logs branch 2 times, most recently from 4c2276a to a82d61d Compare May 14, 2025 17:57
@pront pront marked this pull request as ready for review May 14, 2025 17:58
@pront pront requested a review from a team as a code owner May 14, 2025 17:58
@pront pront force-pushed the pront/fix-e2e-dd-logs branch from a82d61d to efccefb Compare May 14, 2025 17:58
@pront pront force-pushed the pront/fix-e2e-dd-logs branch from efccefb to 8f4fab3 Compare May 14, 2025 18:11
Copy link
Member Author
@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-integration-datadog-logs

@pront pront merged commit 689a65d into master May 14, 2025
88 of 90 checks passed
@pront pront deleted the pront/fix-e2e-dd-logs branch May 14, 2025 18:45
@pront
Copy link
Member Author
pront commented May 14, 2025

This didn't fix the original CI failure but it has multiple desirable changes that will help debugging in the future. Merged this manually and on the next failure I will investigate again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0