8000 chore(transforms): Move `TransformOutputsBuf` functions out of test flag by 20agbekodo · Pull Request #23116 · vectordotdev/vector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(transforms): Move TransformOutputsBuf functions out of test flag #23116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

chore(transforms): Move TransformOutputsBuf functions out of test flag #23116

merged 3 commits into from
May 28, 2025

Conversation

20agbekodo
Copy link
Contributor
@20agbekodo 20agbekodo commented May 27, 2025 •
edited
Loading

Summary

Move the take_primary(), take_all_named(), drain() and drain_named() functions of the remap transform outside of the test feature flag, so the primary_buffer of the output TransformOutputBuf object can be accessed in non-test code.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label May 27, 2025
@20agbekodo 20agbekodo changed the title chores(remap transform): Move take_primary() out of test flag chore(remap transform): Move take_primary() out of test flag May 27, 2025
@20agbekodo 20agbekodo force-pushed the josue.agbekodo/OPA-3328-vector-make-remap-function-accessible-from-outside-its-module branch 5 times, most recently from 07d06da to 6ec697a Compare May 27, 2025 22:43
@bruceg bruceg added type: tech debt A code change that does not add user value. no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels May 28, 2025
bruceg
bruceg reviewed May 28, 2025
View reviewed changes
@20agbekodo 20agbekodo force-pushed the josue.agbekodo/OPA-3328-vector-make-remap-function-accessible-from-outside-its-module branch from 6ec697a to 9ea9e72 Compare May 28, 2025 13:01
@bruceg bruceg changed the title chore(remap transform): Move take_primary() out of test flag chore(transforms): Move TransformOutputsBuf functions out of test flag May 28, 2025
@20agbekodo 20agbekodo marked this pull request as ready for review May 28, 2025 14:01
@20agbekodo 20agbekodo requested a review from a team as a code owner May 28, 2025 14:01
jszwedko
jszwedko reviewed May 28, 2025
View reviewed changes
Copy link
Member
@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few check failures, otherwise 👍

@20agbekodo 20agbekodo added this pull request to the merge queue May 28, 2025
Merged via the queue into vectordotdev:master with commit 3528fc1 May 28, 2025
56 checks passed
@20agbekodo 20agbekodo deleted the josue.agbekodo/OPA-3328-vector-make-remap-function-accessible-from-outside-its-module branch May 28, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko left review comments

@bruceg bruceg bruceg approved these changes

Assignees
No one assigned
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@20agbekodo @jszwedko @bruceg
0