8000 "There is no thing at point that could be edited" when trying to edit an issue · Issue #368 · vermiculus/magithub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"There is no thing at point that could be edited" when trying to edit an issue #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DrWaleedAYousef opened this issue Aug 31, 2018 · 11 comments
Open

"There is no thing at point that could be edited" when trying to edit an issue #368

DrWaleedAYousef opened this issue Aug 31, 2018 · 11 comments
Labels
enhancement idea for a new feature or refinement of existing functionality

Comments

@DrWaleedAYousef
Copy link

When "enter" an issue, then try to edit it (not commenting) this message is given in the mini-buffer:
"There is no thing at point that could be edited"
@vermiculus vermiculus added the enhancement idea for a new feature or refinement of existing functionality label Sep 7, 2018
@vermiculus
Copy link
Owner

This is not yet supported.

@DrWaleedAYousef
Copy link
Author

So you mean I only can create a new issue from magithub but cannot edit it; right?

@vermiculus
Copy link
Owner

As of today, yes. This could change in the future provided I find the time to implement it (or some brave soul submits a PR).

@DrWaleedAYousef
Copy link
Author

Thanks so much

@vermiculus
Copy link
Owner

Leaving open as an enhancement.

@vermiculus vermiculus reopened this Sep 8, 2018
@ccressent
Copy link

Any chance we can change the message in the meantime?

I too was scratching my head about "nothing at point that could be edited" when trying to edit an issue :(

@vermiculus
Copy link
Owner

It's a standard message provided by magithub-edit-thing. I'd be fine with changing the message, but it would need to make sense for anything you might want to edit.

@ccressent
Copy link

I'm a beginner elisper, but it looks like magithub-edit-thing is purely and simply not implemented (source here)? What about changing the error to something like "This operation is not supported yet."?

I imagine that down the road, magithub-edit-thing is going to look at what's at point and call different functions accordingly, ie: magithub-comment-edit if it's a comment, ...?

@vermiculus
Copy link
Owner
vermiculus commented Sep 14, 2018 •
edited
Loading

Not quite. In fact, magithub-edit-thing is remapped to different functions in different keymaps.

@ccressent
Copy link

I see, now I understand better your dilemma with changing the message!

@ibizaman
Copy link

#386 implements this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement idea for a new feature or refinement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ibizaman @ccressent @vermiculus @DrWaleedAYousef
0