-
Notifications
You must be signed in to change notification settings - Fork 63
Allow to edit issue and pull request title and body #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Beautiful; I'll pull and test these changes tonight. Thanks! |
Btw I don't think there's a need to change the manual as it is IMO already suggesting one can do what this PR adds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small question.
With :content, when opening and aborting (C-c C-k) without making changes, magithub asks if user wants to save the draft. On an edit action this doesn't make sense.
@vermiculus (FYI, this is ready for a second review) |
Reviewing now; thanks for your patience :-) There will likely be a few things I want to change in the implementation -- is it alright if I push to your branch? I will say that I ultimately intend to remove issue- and PR-creating capability from Magithub in favor of Forge functionality. |
@vermiculus yes of course! |
Any chance this can get merged? |
At this time I recommend moving to Forge (which I believe supports this; I may be wrong) unless you have a particular reason you need to keep using Magithub. |
No reason apart nostalgia. |
You're free to keep using magithub of course :-) but I have every intention of discontinuing it and pulling it from MELPA by the end of the year. This may seem drastic but I feel pretty strongly about not fracturing the community with competing, incompatible solutions. |
Agreed on not fracturing. I moved to forge in the meantime. Thanks for maintaining this project! |
Adds enhancement for issue #385.
I don't really know what to show you as test apart from saying I edited this PR and the related issue by pressing
e
when viewing the issue. I could correctly change the title and body of the issue/PR.