8000 Allow to edit issue and pull request title and body by ibizaman · Pull Request #386 · vermiculus/magithub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow to edit issue and pull request title and body #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Allow to edit issue and pull request title and body #386

wants to merge 6 commits into from

Conversation

ibizaman
Copy link
@ibizaman ibizaman commented Nov 13, 2018

Adds enhancement for issue #385.

I don't really know what to show you as test apart from saying I edited this PR and the related issue by pressing e when viewing the issue. I could correctly change the title and body of the issue/PR.

@ibizaman ibizaman changed the title allow to edit issue and pull request title and body Allow to edit issue and pull request title and body Nov 13, 2018
@vermiculus
Copy link
Owner

Beautiful; I'll pull and test these changes tonight. Thanks!

@ibizaman
Copy link
Author
ibizaman commented Nov 13, 2018

Btw I don't think there's a need to change the manual as it is IMO already suggesting one can do what this PR adds.

Copy link
Owner
@vermiculus vermiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small question.

With :content, when opening and aborting (C-c C-k) without making
changes, magithub asks if user wants to save the draft. On an edit
action this doesn't make sense.
@Stebalien
Copy link

@vermiculus (FYI, this is ready for a second review)

@vermiculus
Copy link
Owner

Reviewing now; thanks for your patience :-) There will likely be a few things I want to change in the implementation -- is it alright if I push to your branch?

I will say that I ultimately intend to remove issue- and PR-creating capability from Magithub in favor of Forge functionality.

@ibizaman
Copy link
Author
ibizaman commented Jan 2, 2019

@vermiculus yes of course!

@JustinD85
Copy link

Any chance this can get merged?

@vermiculus
Copy link
Owner

At this time I recommend moving to Forge (which I believe supports this; I may be wrong) unless you have a particular reason you need to keep using Magithub.

@ibizaman
Copy link
Author

No reason apart nostalgia.
Should I switch completely to Forge?

@vermiculus
Copy link
Owner
vermiculus commented Mar 28, 2019

You're free to keep using magithub of course :-) but I have every intention of discontinuing it and pulling it from MELPA by the end of the year.

This may seem drastic but I feel pretty strongly about not fracturing the community with competing, incompatible solutions.

@ibizaman
Copy link
Author

Agreed on not fracturing. I moved to forge in the meantime. Thanks for maintaining this project!

@ibizaman ibizaman closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0