Add validation for MAC and IP addresses in Measurement.Valid method #143
Conversation
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
There was a problem hiding this comment.
@ravjot07 thanks again for your contribution.
I have left a comment about supporting EUI-64 which should be easy to fix.
comid/measurement.go
Outdated
| // Validate MAC Address | ||
| if o.MACAddr != nil { | ||
| if len(*o.MACAddr) != 6 { // MAC address must be exactly 6 bytes | ||
| return fmt.Errorf("invalid MAC address length: expected 6 bytes, got %d", len(*o.MACAddr)) | ||
| } | ||
| } |
There was a problem hiding this comment.
The CoRIM spec allows for {MAC,EUI}-48 as well as EUI-64 formatted MAC addresses:
mac-addr-type-choice = eui48-addr-type / eui64-addr-type
eui48-addr-type = bytes .size 6
eui64-addr-type = bytes .size 8
Therefore, 8 is acceptable too.
There was a problem hiding this comment.
@thomas-fossati i have updated MAC address validation to allow EUI-48 and EUI-64 formats
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
comid/test_vars.go
Outdated
| @@ -26,7 +26,7 @@ var ( | |||
| }) | |||
| TestOID = "2.5.2.8192" | |||
| TestRegID = "https://acme.example" | |||
| TestMACaddr, _ = net.ParseMAC("02:00:5e:10:00:00:00:01") | |||
There was a problem hiding this comment.
Last thing, I promise ;-)
If you revert this, the diff is smaller since the change to comid/example_test.go becomes unnecessary.
There was a problem hiding this comment.
@thomas-fossati pl review sir
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
Thanks @thomas-fossati for your reviews and guidance, any other changes?? |
Measurement.Validmethod, addressing the TODO comment: "MAC addr & friends."This PR close #18