Update golangci-lint version to v2 #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci-lint v2 uses a different syntax and has deprecated some checks. gosimple has been merged into staticcheck. typecheck is not a linter and has been removed. maligned has been deprecated. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Issue veraison#192 Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Concrete values in tests are valuable for clearer auditability to determine correctness. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Abstracting test logic into methods is generally not the best practice in order to keep tests self-contained and locally auditable for correctness. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Resolves gosec errors. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
When `const`, values are typeless, which allows for safe interpretation into different types. This resolves an otherwise erroneous int conversion safety error from gosec. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
The gosec linter does not approve of os.ReadFile in tests. It's better to make the test data into constants directly usable by tests using go:embed. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
thomas-fossati
approved these changes
Jun 18, 2025
setrofim
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves all existing linter errors except for
revive, which will take more editorial insight for documentation purposes.Issue #192 tracks the re-enabling of the
revivelinter.