Remove sync trigger when connecting #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request removes the synchronization logic from data connections by removing the sync effect and associated constants.
- Removed the sync trigger code in DataConnectionsProvider
- Removed the DATA_CONNECTIONS_SYNC_INTERVAL constant from constants.ts
Reviewed Changes
| File | Description |
|---|---|
| src/features/data-connections/components/data-connections-provider.tsx | Removed synchronization logic, including sync effects and imports |
| src/features/data-connections/constants.ts | Removed the DATA_CONNECTIONS_SYNC_INTERVAL constant |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the data connections feature, focusing on removing the synchronization logic and related constants. The most important changes include the removal of the synchronization interval constant and the associated synchronization logic within the
DataConnectionsProvidercomponent.Removal of synchronization logic:
src/features/data-connections/components/data-connections-provider.tsx: Removed the import and usage ofDATA_CONNECTIONS_SYNC_INTERVALanduseSyncAllDataConnections, including the effect that handled synchronization at startup and at regular intervals. [1] [2]Removal of related constants:
src/features/data-connections/constants.ts: Removed theDATA_CONNECTIONS_SYNC_INTERVALconstant.