Fix segfault on using type in parameterized classes without #() (#4281) #4440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsnyder
reviewed
Aug 26, 2023
Co-authored-by: Wilson Snyder <wsnyder@wsnyder.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue (#4281) is basically caused by two factors.
The first is that the code contains reference to a type declared inside a parameterized class (
C::a_ch_t) and this should be reported as a "Reference to parameterized class without #() (IEEE 1800-2017 8.25.1)" error in V3LinkDot. However, theLinkDotResolverVisitor::visit(AstRefDType* nodep)mistakenly treat it as a normal class reference, so the type is resolved and the AstClassOrPackageRef is removed, preventing it from entering the checking function (LinkDotResolverVisitor::visit(AstClassOrPackageRef* nodep)) to emit the error. After it goes to V3Param, since the AstClassOrPackageRef was removed, V3Param may regard the referenced class as unused and then remove it, which caused the later segfault.Beside, the use of user2p in V3Param conflicts with the constant simulation function. It's now replaced with user4p to prevent any errors.