8000 Application Commands fix. by false-fox · Pull Request #629 · victornpb/undiscord · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Application Commands fix. #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Application Commands fix. #629

wants to merge 8 commits into from
+16 −4

Conversation

false-fox
Copy link
@false-fox false-fox commented May 21, 2024 •
edited
Loading

Fixes #476, #526, #535 (partially) and #487. Undiscord attempts to delete application/bot messages initialized by the user, but receives a 403 error and hangs.

I added a filter to the messageToDelete array to exclude bots, and a coresponding menu option to toggle the feature.

Features

Provides a UI option under the filter category

imssage

Provides a console log that bot messages will be skipped

asdasdasdasdasdasd

Works on an elegantly simple filter.

~line 318 of undiscord-core.js

if (this.options.IncludeApplications == false) {
    messagesToDelete = messagesToDelete.filter(msg => !msg.author.bot)
}

Notes

I figured including application messages should be "opt in" as in most use cases users won't have manage messages perms. Let me know if this should be changed and it's a simple fix.

This was referenced May 21, 2024
Open
Open
Open
Open
@ivystopia
Copy link

This branch fixed #487 for me

@victornpb victornpb added the PR looks good Looks like it's good for merging (maybe be in the next release) label Mar 9, 2025
@jake983394
Copy link

does anyone have a fix for this? i type in what false-fox has said to the code but it doesn't seem to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR looks good Looks like it's good for merging (maybe be in the next release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slash Commands are being reported as belonging to user but can't be deleted.
4 participants
@false-fox @ivystopia @jake983394 @victornpb
0