8000 Included selected_channels and selected_columns in request analysis method signature by vnadhan · Pull Request #101 · vikinganalytics/mvg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Included selected_channels and selected_columns in request analysis method signature #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2021
Merged

Included selected_channels and selected_columns in request analysis method signature #101

merged 3 commits into from
Nov 19, 2021

Conversation

vnadhan
Copy link
Contributor
@vnadhan vnadhan commented Nov 15, 2021 •
edited
Loading

Checklist

  • Update mvg version
  • Update backend version

What does the PR close?

closes #97

What does the PR solve/fix/add?

  • Earlier, request_analysis and request_population_analysis method allowed passing selected_channels and selected_columns as keys inside the parameters dictionary. Now, new method parameters selected_channels and selected_columns have been added to both the methods, which can be used to perform the same capability as before.
  • Note: selected_channels and selected_columns can still be injected into the parameters dictionary, but if the method arguments are given a valid value (other than None or []), the latter will be given preference

Test cases

None

@vnadhan vnadhan marked this pull request as draft November 15, 2021 18:07
@vnadhan vnadhan marked this pull request as ready for review November 15, 2021 19:04
SergioMDCB
SergioMDCB approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor
@SergioMDCB SergioMDCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR incorporates the parameters requested_channels and requested_columns in the request_analysis function

@SergioMDCB SergioMDCB merged commit 35248b0 into master Nov 19, 2021
@SergioMDCB SergioMDCB deleted the issue_97 branch November 19, 2021 09:32
@SergioMDCB SergioMDCB mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuix tuix tuix approved these changes

@SergioMDCB SergioMDCB SergioMDCB approved these changes

@claezon claezon Awaiting requested review from claezon

@OskarLiew OskarLiew Awaiting requested review from OskarLiew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add selected_columns and selected_channels to request analysis methods
3 participants
@vnadhan @tuix @SergioMDCB
0