Added MVG errors with better error messages #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuix
previously requested changes
Nov 30, 2021
tests/test_errors.py
Outdated
Comment on lines
25
to
31
| def mock_fail_request(json_body): | ||
| return MockResponse(400, "Bad Request", json_body) | ||
|
|
||
|
|
||
| def assert_fail_response(msg, detail="No error message"): | ||
| assert msg == f"400 - Bad Request: {detail}" | ||
|
8000
|
There was a problem hiding this comment.
How are these two functions used? Do not seem to be invoked by other functions, and won't be called as a test function by pytest either?
There was a problem hiding this comment.
These were just something I was playing around with but decided was overkill. Seems I forgot to remove the functions
vnadhan
requested changes
Dec 3, 2021
|
Just found two minor issues in the documentation, otherwise good work @OskarLiew! |
|
I tested this branch locally and it is now much easier to know what caused an error, however they are too lengthy with unwanted characters or detail. This is an error that happened when a source id has a space in it. Perhaps we should improve the errors we send out from the backend. |
vnadhan
previously approved these changes
Dec 6, 2021
vnadhan
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new MVG specific errors. In particular
MVGAPIErrorthat will automatically read the details of the error messageNew dependencies: (Added to requirements_*.txt)
Fixes #43 (potential issues that are fixed by this PR)
Type of Change
Checklist
Requirements