8000 Force parameter in request analysis calls by vnadhan · Pull Request #194 · vikinganalytics/mvg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Force parameter in request analysis calls #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2023
Merged

Force parameter in request analysis calls #194

merged 3 commits into from
Feb 3, 2023

Conversation

vnadhan
Copy link
Contributor
@vnadhan vnadhan commented Jan 31, 2023 •
edited by tuix
Loading

Description

Include force parameter in request analysis and request population analysis calls

New dependencies: None

Fixes #193

Type of Change

  • Bug fix (non-breaking change which fixes an issue -> bump patch)
  • New feature (non-breaking change which adds functionality -> bump minor version)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected -> bump major version)
  • Documentation Update
  • CI/CD workflows Update

Checklist

  • I have added tests that prove that my fix/feature works
  • Linters pass locally and I have followed PEP8 code style
  • New and existing tests pass locally
  • I have updated the documentation if needed
  • I have commented hard-to-understand areas in the code

Requirements

  • I have updated the MVG version

@codecov
Copy link
codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Base: 72.14% // Head: 72.14% // No change to project coverage 👍

Coverage data is based on head (74a2509) compared to base (5ee949b).
Patch coverage: 75.00% of modified lines in pull request are covered.

❗ Current head 74a2509 differs from pull request most recent head 27d0f68. Consider uploading reports for the commit 27d0f68 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          11       11           
  Lines         858      858           
=======================================
  Hits          619      619           
  Misses        239      239
Impacted Files Coverage Δ
mvg/mvg.py 88.38% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tuix tuix self-assigned this Jan 31, 2023
claezon
claezon reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor
@claezon claezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions regarding docstrings.

SergioMDCB
SergioMDCB previously approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor
@SergioMDCB SergioMDCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and really nice that this PR was used as a good opportunity to update the spelling mistakes

vnadhan and others added 3 commits February 3, 2023 14:43
@vnadhan
Force parameter in request analysis
860fb04 
- Also includes fixing grammatical errors
@vnadhan
Bump MVG / API version
16be2e6
@vnadhan @claezon
Fix docstrings
27d0f68 
Co-Authored-By: Rickard Claeson <rickard.claeson@clajori.se>
@vnadhan vnadhan requested review from claezon and tuix and removed request for tuix February 3, 2023 10:15
@tuix tuix merged commit 8c46cc5 into master Feb 3, 2023
@tuix tuix deleted the issue_193 branch February 3, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuix tuix tuix approved these changes

@SergioMDCB SergioMDCB SergioMDCB left review comments

@claezon claezon Awaiting requested review from claezon

Assignees

@tuix tuix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add force parameter in request_analysis
4 participants
@vnadhan @tuix @claezon @SergioMDCB
0