8000 Get customized analysis results with result_type by vnadhan · Pull Request #205 · vikinganalytics/mvg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get customized analysis results with result_type #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2023
Merged

Get customized analysis results with result_type #205

merged 4 commits into from
Mar 28, 2023

Conversation

vnadhan
Copy link
Contributor
@vnadhan vnadhan commented Mar 27, 2023 •
edited
Loading

Description

Include a summary of this pull request

New dependencies: (Added to requirements_*.txt)

Fixes # (potential issues that are fixed by this PR)

Type of Change

  • Bug fix (non-breaking change which fixes an issue -> bump patch)
  • New feature (non-breaking change which adds functionality -> bump minor version)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected -> bump major version)
  • Documentation Update
  • CI/CD workflows Update

Checklist

  • I have added tests that prove that my fix/feature works
  • Linters pass locally and I have followed PEP8 code style
  • New and existing tests pass locally
  • I have updated the documentation if needed
  • I have commented hard-to-understand areas in the code

Requirements

  • I have updated the MVG version

@vnadhan vnadhan changed the title Include result_type in get analysis results Get customized analysis results with result_type Mar 28, 2023
tuix
tuix suggested changes Mar 28, 2023
View reviewed changes
@vnadhan vnadhan force-pushed the include-result-type branch from a95156b to e8b1c7b Compare March 28, 2023 14:07
@vnadhan vnadhan force-pushed the include-result-type branch from e8b1c7b to 0d53d09 Compare March 28, 2023 14:08
@codecov
Copy link
codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.02 🎉

Comparison is base (9b9b82d) 73.08% compared to head (c569271) 73.11%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   73.08%   73.11%   +0.02%     
==========================================
  Files          12       12              
  Lines         914      915       +1     
==========================================
+ Hits          668      669       +1     
  Misses        246      246
Impacted Files Coverage Δ
mvg/utils/response_processing.py 76.19% <0.00%> (-0.56%) ⬇️
mvg/mvg.py 89.84% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vnadhan vnadhan merged commit 252819d into master Mar 28, 2023
@vnadhan vnadhan deleted the include-result-type branch March 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuix tuix tuix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnadhan @tuix
0