Upload spectrum data support #207
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 73.11% 73.67% +0.55%
==========================================
Files 12 12
Lines 915 942 +27
==========================================
+ Hits 669 694 +25
- Misses 246 248 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@pro100watt Thanks for the working on this feature in a rapid manner. Good work on maintaining consistency in the file mvg.py. More attention could be given to the proper naming of stub data in the test suite. You can look at the conftest in vibium-pipeline / vibium-cloud to look at the naming of the fixtures (that create sources and measurements) and the output of those fixtures.
It is good for you to know we want to move away from hard coded data that is used widely in MVG and we will instead generate and use random data for the measurements.
| Although it is up to the client side to handle the | ||
| scaling of data it is recommended that the values | ||
| represent the acceleration in g. | ||
| The timestamp shall represent the time when the measurement was | ||
| recorded. |
There was a problem hiding this comment.
@tuix Could you review this description? This is a copy of the description for create_measurement. For spectrum measurement, do we need to provide this recommendation that the spectrum data could be in units of
acceleration?
- Improve fixture that creates spectrum sources - Use simulated spectrum measurements - Name of a test case should start with the name of the tested method
6df1833 to
e63decd
Compare
602e898 to
e405d19
Compare
... by asking pydantic to import the binary file of pydantic to be be able to get all the modules present in pydantic package
There was a problem hiding this comment.
@pro100watt Raman, thanks again for working on this issue. I have refactored your code in the test suite to make it more aligned with what we have developed so far in other vibium products.
I identified that a deprecated attribute of one of the methods from pandas was used in plotting.py that led to the failure in one of the notebooks.
I noticed that you had added a disabler for a pylint instruction no-name-in-module and this was due to the pydantic package. I removed the disabler and instead added the extension-pkg-whitelist to allow pylint to work with pydantic modules.
I will approve this PR and if you have comments on my commits, please let me know.
Description
Added
create_spectrum_sourceandcreate_spectrum_measurementmethods toMVGAPI.New dependencies:
requirements.txt: pydantic
Fixes #206
Type of Change
Checklist
Requirements