8000 API should only return measurements without data for each measurement by vnadhan · Pull Request #22 · vikinganalytics/mvg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

API should only return measurements without data for each measurement #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2021
Merged

API should only return measurements without data for each measurement #22

merged 2 commits into from
Jun 4, 2021

Conversation

vnadhan
Copy link
Contributor
@vnadhan vnadhan commented Jun 3, 2021

Summary

TODO: Update the example ipynbs in the docs folder

@vnadhan vnadhan requested review from tuix and SergioMDCB June 3, 2021 13:27
SergioMDCB
SergioMDCB reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor
@SergioMDCB SergioMDCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the call for the entire timeseries for each measurement.
Just a minor comment/update on the function description for clarity.

tuix
tuix suggested changes Jun 3, 2021
View reviewed changes
@vnadhan vnadhan requested review from tuix and SergioMDCB June 3, 2021 15:43
@vnadhan
Copy link
Contributor Author
vnadhan commented Jun 3, 2021

@tuix @SergioMDCB
I have not updated the docs. I will update the docs in another PR when a new release for MVG is done.

@SergioMDCB
Copy link
Contributor
SergioMDCB commented Jun 3, 2021 via email •
edited by tuix
Loading

SergioMDCB
SergioMDCB approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor
@SergioMDCB SergioMDCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR renames the read_measurements function to list_measurements and provides with the metadata of the measurements only instead of the full data

@SergioMDCB SergioMDCB merged commit 9d48a8b into master Jun 4, 2021
@vnadhan vnadhan deleted the issue_17 branch June 7, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuix tuix tuix approved these changes

@SergioMDCB SergioMDCB SergioMDCB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_measuremnts() should conform to API definition
3 participants
@vnadhan @SergioMDCB @tuix
0