8000 Use required meta for sources by pavradev · Pull Request #221 · vikinganalytics/mvg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use required meta for sources #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2023
Merged

Use required meta for sources #221

merged 4 commits into from
Aug 14, 2023

Conversation

pavradev
Copy link
Contributor
@pavradev pavradev commented Aug 11, 2023 •
edited
Loading

Description

This PR adds required metadata for sources according to the latest changes in vibium-cloud

Fixes https://github.com/vikinganalytics/vibium-cloud/issues/934

Type of Change

  • Bug fix (non-breaking change which fixes an issue -> bump patch)
  • New feature (non-breaking change which adds functionality -> bump minor version)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected -> bump major version)
  • Documentation Update
  • CI/CD workflows Update

Checklist

  • I have added tests that prove that my fix/feature works
  • Linters pass locally and I have followed PEP8 code style
  • New and existing tests pass locally
  • I have updated the documentation if needed
  • I have commented hard-to-understand areas in the code

Requirements

  • I have updated the MVG version

@codecov
Copy link
codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (724549a) 75.28% compared to head (47c2721) 75.28%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   75.28%   75.28%           
=======================================
  Files          12       12           
  Lines         955      955           
=======================================
  Hits          719      719           
  Misses        236      236
Files Changed Coverage Δ
mvg/mvg.py 90.80% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavradev pavradev requested a review from vnadhan August 11, 2023 08:52
@vnadhan
Copy link
Contributor
vnadhan commented Aug 11, 2023

@pavradev I would also like to see a writeup in the docstring for mvg.create_source on how to build the metadata. It would be helpful for the customers who use the MVG library to better know how to create a source.

@pavradev
Copy link
Contributor Author

@pavradev I would also like to see a writeup in the docstring for mvg.create_source on how to build the metadata. It would be helpful for the customers who use the MVG library to better know how to create a source.

Added

@pavradev pavradev merged commit 81a90c8 into master Aug 14, 2023
@pavradev pavradev deleted the enforce_meta branch August 14, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnadhan vnadhan vnadhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavradev @vnadhan
0