consistenthash: split GetReplicated with go 1.23 range functions #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
Apr 15, 2025
Use build-tagged files to provide range-function (go 1.23+ iterators) internally so we can pull out loops over all the hashes for a key or ownerKey. (leave a build-tagged file with the older version in-place for backwards compatibility)
f217ab4 to
fba3f6a
Compare
6a9e4a1 to
97c22a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use build-tagged files to provide range-function (go 1.23+ iterators)
internally so we can pull out loops over all the hashes for a key or
ownerKey. (leave a build-tagged file with the older version in-place for
backwards compatibility)