chtest: fix segments-per-key calculation & add layout explanation #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing the initial version of this package, I did a back of the envelope calculation, and forgot to draw myself a full diagram for the n=2 and n=3 cases, meaning that I didn't actually _count_ how many entries I needed with the layout I had. Writing it down and counting showed that I was off by a factor of 2. (which also jives with the sizes of the internal maps/slices this package creates (which are unfortunately only visible in a debugger because they're only propagated by the hash-function closure's capture)
Since I needed to write this down on paper to understand the map myself, I might as well add add a doc-comment that explains it in detail for everyone. (including future me)
sergiosalvatore
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chtest: fix segments_per_key calculation
When writing the initial version of this package, I did a back of the
envelope calculation, and forgot to draw myself a full diagram for the
n=2 and n=3 cases, meaning that I didn't actually count how many
entries I needed with the layout I had. Writing it down and counting
showed that I was off by a factor of 2. (which also jives with the sizes
of the internal maps/slices this package creates (which are
unfortunately only visible in a debugger because they're only propagated
by the hash-function closure's capture)
chtest: add block comment explaining hash layout
Since I needed to write this down on paper to understand the map myself,
I might as well add add a doc-comment that explains it in detail for
everyone. (including future me)